Page 1 of 1

S3 Trio64 1mb reports as 2mb

Posted: Sun 26 Nov, 2017 7:32 am
by leilei
This must have been some sort of regression since the October commits between the 16th and Nov 1st.

It'll show all the resolutions it shouldn't do and crash the emulator when you choose one of them.

My BIOS is dumped from a 1mb card, so I doubt it's that...

this nasty surprise came after happening to run The Labyrinth which was set to primary display for a menu-testing reason, nearly reported this as a fatal V2 bug but turns out it's doing illegal accesses of memory it can't use for a double-buffered 640x480x16

Re: S3 Trio64 1mb reports as 2mb

Posted: Sun 26 Nov, 2017 12:22 pm
by omarsis81
It is the one included in Windows XP's Plus?

Re: S3 Trio64 1mb reports as 2mb

Posted: Sun 26 Nov, 2017 2:20 pm
by SA1988
Pheraps you might take a look at the s3_init function to know that the culprit is there, especially the vram_max part.

Re: S3 Trio64 1mb reports as 2mb

Posted: Sun 26 Nov, 2017 8:43 pm
by SarahWalker
Seems to work okay here. Which Trio64 driver are you using?

Re: S3 Trio64 1mb reports as 2mb

Posted: Sun 26 Nov, 2017 11:09 pm
by leilei
The stock S3 Trio64 driver with Windows 98SE and also the DirectX 5-provided S3 Trio64 driver (on Windows 95).

These drivers reported 1mb back in mid-October.


EDIT: Scitech Display Doctor also erroneously reports it as a 2MB card.

Re: S3 Trio64 1mb reports as 2mb

Posted: Mon 27 Nov, 2017 8:05 pm
by SarahWalker
I have a suspicion as to what the problem may be. leilei, could you confirm if the board you dumped the BIOS from has FPM or EDO memory? A quick google of the RAM part number should say one way or another.

I _think_ that there's a difference in how memory is mapped between the FPM and EDO versions of the card. I confirmed in October that my FPM card wraps memory at 1MB if only 1MB is present, but the Phoenix BIOS that I have (which is definitely from an EDO card) expects it not to wrap.

Re: S3 Trio64 1mb reports as 2mb

Posted: Tue 28 Nov, 2017 12:27 am
by leilei
It's a Phoenix-based BIOS and i'm fairly certain it's an EDO card IIRC.

EDIT: two chips of SM81C256KA1-40

Re: S3 Trio64 1mb reports as 2mb

Posted: Tue 28 Nov, 2017 7:49 pm
by SarahWalker
Yep, that looks like EDO. I've committed my fix at rev 941.

Technically I should probably also limit this card to 2 MB, as the Trio64 only supports 4 MB with FPM. I'd probably get shouted at though.