Question about commit 8c60f50

Discussion of development and patch submission.
Post Reply
altheos
Posts: 44
Joined: Wed 24 Feb, 2016 7:27 pm

Question about commit 8c60f50

Post by altheos » Mon 19 Feb, 2018 9:37 am

Hi,

Sarah : can you explain me why you did this

Code: Select all

svga->hwcursor.addr = (0x1fc000 + ((val & 0x3f) * 256)) & svga->vram_mask;
instead of

Code: Select all

svga->hwcursor.addr = (vram_size-0x4000) + ((val & 0x3f) * 256);
as the first prevent an hypotetical 4 Mo display memory ?
The docs says that the hardware cursors are located in the upper 16k of display memory (or upper 4K of each logical memory plane).

Regards

User avatar
SarahWalker
Site Admin
Posts: 1541
Joined: Thu 24 Apr, 2014 4:18 pm

Re: Question about commit 8c60f50

Post by SarahWalker » Mon 19 Feb, 2018 6:04 pm

0x1fc000 has been there for years before I picked up the GD5429 again, and I try to modify as little code as possible for each change. Also the currently emulated cards don't support 4MB anyway.

Post Reply