ide_atapi.c missing a brace?

Discussion of development and patch submission.
Post Reply
bloodbat
Posts: 17
Joined: Thu 10 Mar, 2016 4:36 am

ide_atapi.c missing a brace?

Post by bloodbat »

While compiling the 7d3c176 commit with GCC 7.2.0 using -Wall and -Werror I get an error about misleading indentation in line 266, looking at the code, it seems to be missing a brace?

Code: Select all

 if (ide_bus_master_write_data)
                                                        {
                                                                if (ide_bus_master_write_data(atapi_dev->board, atapi_dev->data, atapi_dev->data_read_pos))
                                                                {
                                                                        atapi_dev->state = ATAPI_STATE_RETRY_WRITE_DMA;
                                                                        idecallback[atapi_dev->board] = 1*IDE_TIME;
                                                                }
                                                                else

                                                                        atapi_dev->data_write_pos = atapi_dev->data_read_pos;                                                                {
                                                                        atapi_dev->bus_state = 0;
                                                                        atapi_dev->state = ATAPI_STATE_WRITE_DATA;
                                                                        idecallback[atapi_dev->board] = 6 * IDE_TIME;
                                                                }
                                                        }
darksabre76
Posts: 69
Joined: Tue 12 Sep, 2017 4:33 am
Location: Seattle, WA, USA
Contact:

Re: ide_atapi.c missing a brace?

Post by darksabre76 »

Looks like the brace got moved accidentally to the end of the first line under else.
User avatar
SarahWalker
Site Admin
Posts: 2054
Joined: Thu 24 Apr, 2014 4:18 pm

Re: ide_atapi.c missing a brace?

Post by SarahWalker »

Fixed in rev 1109.
bloodbat
Posts: 17
Joined: Thu 10 Mar, 2016 4:36 am

Re: ide_atapi.c missing a brace?

Post by bloodbat »

Thanks :)
Post Reply