[PATCH] crash fix when using direct3D and minimizing

Discussion of development and patch submission.
JosepMa
Posts: 70
Joined: Tue 20 Jun, 2017 6:25 pm

[PATCH] crash fix when using direct3D and minimizing

Postby JosepMa » Sat 08 Jul, 2017 2:41 pm

I've located and fixed a very annoying bug that would crash PCem whenever Direct3D was enabled and the user clicked to minimize the window.

The crash was actually a fatal() called when the rendering fails (which it does, when the window is minimized).
Attachments
bugfix-crash-on-minimize-Direct3d.patch
patch crash when on direct3d and minimizing
(2.25 KiB) Downloaded 26 times
SarahWalker
Site Admin
Posts: 1325
Joined: Thu 24 Apr, 2014 4:18 pm

Re: [PATCH] crash fix when using direct3D and minimizing

Postby SarahWalker » Sun 09 Jul, 2017 6:06 pm

Committed at rev 792.
Roman S
Posts: 6
Joined: Wed 31 May, 2017 5:18 pm

Re: [PATCH] crash fix when using direct3D and minimizing

Postby Roman S » Mon 10 Jul, 2017 2:58 pm

Unfortunately, I still can't compile it:

Code: Select all

./configure --prefix=/usr --build=x86_64-pc-linux-gnu --host=x86_64-pc-linux-gnu --mandir=/usr/share/man --infodir=/usr/share/info --datadir=/usr/share --sysconfdir=/etc --localstatedir=/var/lib --disable-dependency-tracking --disable-silent-rules --docdir=/usr/share/doc/pcem-9999 --htmldir=/usr/share/doc/pcem-9999/html --libdir=/usr/lib64 --enable-wx

(...)


x86_64-pc-linux-gnu-gcc -DPACKAGE_NAME=\"PCem\" -DPACKAGE_TARNAME=\"pcem\" -DPACKAGE_VERSION=\"v12\" -DPACKAGE_STRING=\"PCem\ v12\" -DPACKAGE_BUGREPORT=\"Sarah\ Walker\ \<pcem@pcem-emulator.co.uk\>\" -DPACKAGE_URL=\"\" -DPACKAGE=\"pcem\" -DVERSION=\"v12\" -DHAVE_LIBOPENAL=1 -DHAVE_LIBALUT=1 -DHAVE_LIBPTHREAD=1 -I.    -I/usr/lib64/wx/include/gtk2-unicode-3.0 -I/usr/include/wx-3.0 -D_FILE_OFFSET_BITS=64 -DWXUSINGDLL -D__WXGTK__ -pthread -I/usr/include/SDL2 -D_REENTRANT  -O3 -c -o pcem-esdi_at.o `test -f 'esdi_at.c' || echo './'`esdi_at.c
esdi_at.c:106:35: error: unknown type name ‘off64_t’
 int esdi_get_sector(esdi_t *esdi, off64_t *addr)
                                   ^~~~~~~
esdi_at.c: In function ‘esdi_callback’:
esdi_at.c:442:9: error: unknown type name ‘off64_t’
         off64_t addr;
         ^~~~~~~
esdi_at.c:498:29: warning: implicit declaration of function ‘esdi_get_sector’ [-Wimplicit-function-declaration]
                         if (esdi_get_sector(esdi, &addr))
                             ^~~~~~~~~~~~~~~
make[1]: *** [Makefile:1228: pcem-esdi_at.o] Error 1
SarahWalker
Site Admin
Posts: 1325
Joined: Thu 24 Apr, 2014 4:18 pm

Re: [PATCH] crash fix when using direct3D and minimizing

Postby SarahWalker » Mon 10 Jul, 2017 8:08 pm

That isn't really related to this thread at all. But try rev 793.
Roman S
Posts: 6
Joined: Wed 31 May, 2017 5:18 pm

Re: [PATCH] crash fix when using direct3D and minimizing

Postby Roman S » Mon 10 Jul, 2017 8:57 pm

Sorry, I was meant to be under the [Linux] GUI discussion thread. I confirm, it compiles now. Thank you!

Return to “Development”

Who is online

Users browsing this forum: No registered users and 2 guests