Patches for wxWidgets/SDL2

Discussion of development and patch submission.
bit
Posts: 98
Joined: Sun 19 Mar, 2017 7:04 pm

Patches for wxWidgets/SDL2

Postby bit » Wed 19 Jul, 2017 9:07 pm

I decided to create a new thread only for patches related to the wxWidgets/SDL2-port to reduce the amount of posts in the other thread.

The first patch I'll provide here is a big one.
The major additions are:
  • An updated UI.
  • OpenGL 3.0 with GLSL/GLSLP-support. GLSLP is used by RetroArch so many of the shaders from there should work.
  • Many updates and improvements to the Windows-version. It should now be more similar to the regular Windows-version.
And lots of minor changes and bugfixes.

The patch was too big to add as an attachment so I've uploaded it here:
https://martinborjesson.com/pcem/170719-wx_updates.7z (1mb)
SarahWalker
Site Admin
Posts: 1333
Joined: Thu 24 Apr, 2014 4:18 pm

Re: Patches for wxWidgets/SDL2

Postby SarahWalker » Sun 30 Jul, 2017 9:45 am

Committed at rev 821.

Could I request that you split patches up a bit more in future? It makes it easier to see what the individual changes are :)
teppic
Posts: 22
Joined: Tue 20 Jun, 2017 12:31 pm

Re: Patches for wxWidgets/SDL2

Postby teppic » Sun 30 Jul, 2017 9:47 am

The new SDL UI is part of the official release now? That's nice for us Linux people :)
bit
Posts: 98
Joined: Sun 19 Mar, 2017 7:04 pm

Re: Patches for wxWidgets/SDL2

Postby bit » Sun 30 Jul, 2017 7:36 pm

SarahWalker wrote:Committed at rev 821.

Could I request that you split patches up a bit more in future? It makes it easier to see what the individual changes are :)

Thanks!

Of course, I'm sorry about that. My larger patch-submissions in the future will not be in one big file :)
Last edited by bit on Sun 30 Jul, 2017 8:41 pm, edited 1 time in total.
bit
Posts: 98
Joined: Sun 19 Mar, 2017 7:04 pm

Re: Patches for wxWidgets/SDL2

Postby bit » Sun 30 Jul, 2017 8:41 pm

Fixed so it can now be built on Windows even if wxrc.exe does not exist, also removed an include that shouldn't be there.
Fixed so the correct value is used for timer_freq.
Updated the configuration manager so that when it is opened again after shutting down the emulated machine that config will be selected.
Attachments
170730-wx_fixes.patch
(1.42 KiB) Downloaded 9 times
170730-wx_active_config.patch
(1.26 KiB) Downloaded 9 times
basic2004
Posts: 118
Joined: Sun 08 Jan, 2017 5:59 pm

Re: Patches for wxWidgets/SDL2

Postby basic2004 » Mon 31 Jul, 2017 5:11 am

Munt 2.2.0 has released.
Newest mt32emu has most accurate old MT-32 emulation and support new MT-32 (2.04) ROMs.
You should update mt32emu.
bit
Posts: 98
Joined: Sun 19 Mar, 2017 7:04 pm

Re: Patches for wxWidgets/SDL2

Postby bit » Mon 31 Jul, 2017 6:30 pm

basic2004 wrote:Munt 2.2.0 has released.
Newest mt32emu has most accurate old MT-32 emulation and support new MT-32 (2.04) ROMs.
You should update mt32emu.

I will take a look at it, thanks for letting me know of the new release :)
bit
Posts: 98
Joined: Sun 19 Mar, 2017 7:04 pm

Re: Patches for wxWidgets/SDL2

Postby bit » Mon 31 Jul, 2017 8:37 pm

This patch adds an option for custom resolution.
Attachments
170731-custom_resolution.patch
(78.49 KiB) Downloaded 11 times
SarahWalker
Site Admin
Posts: 1333
Joined: Thu 24 Apr, 2014 4:18 pm

Re: Patches for wxWidgets/SDL2

Postby SarahWalker » Tue 01 Aug, 2017 11:15 am

Revs 825-828 commit the last three patches.
bit
Posts: 98
Joined: Sun 19 Mar, 2017 7:04 pm

Re: Patches for wxWidgets/SDL2

Postby bit » Thu 10 Aug, 2017 6:50 pm

This patch fixes some issues with shader rendering.
Attachments
170810-shader_fixes.patch
(8.36 KiB) Downloaded 11 times
bit
Posts: 98
Joined: Sun 19 Mar, 2017 7:04 pm

Re: Patches for wxWidgets/SDL2

Postby bit » Sun 13 Aug, 2017 7:33 pm

This patch moves the renderer update-method to prevent the GPU from slowing down the emulation.
Attachments
170813-renderer_update_move.patch
(3.04 KiB) Downloaded 16 times
SarahWalker
Site Admin
Posts: 1333
Joined: Thu 24 Apr, 2014 4:18 pm

Re: Patches for wxWidgets/SDL2

Postby SarahWalker » Tue 15 Aug, 2017 8:35 pm

Shader rendering fixes committed at rev 846.

I haven't committed the other patch, as it slows the emulator down for me.
ecksemmess
Posts: 122
Joined: Wed 18 Mar, 2015 5:27 am

Re: Patches for wxWidgets/SDL2

Postby ecksemmess » Wed 16 Aug, 2017 3:17 am

That last uncommitted patch is the one that fixed the major problem that killed non-Software-renderer performance for iwasaperson across the board on all emulated machines, right? Seems like something that will have to be re-incorporated somehow, possibly with a setting to allow the user to choose between the two renderer update methods.
bit
Posts: 98
Joined: Sun 19 Mar, 2017 7:04 pm

Re: Patches for wxWidgets/SDL2

Postby bit » Thu 17 Aug, 2017 6:22 pm

I added a setting for it. It can be found in Video -> Alternative update-lock (not sure if that's what it should be called) and it uses the old behavior by default.
It replaces the previous patch.
Attachments
170817-renderer_update_move.patch
(12.12 KiB) Downloaded 9 times
ecksemmess
Posts: 122
Joined: Wed 18 Mar, 2015 5:27 am

Re: Patches for wxWidgets/SDL2

Postby ecksemmess » Thu 17 Aug, 2017 7:40 pm

Looks good. :)
bit
Posts: 98
Joined: Sun 19 Mar, 2017 7:04 pm

Re: Patches for wxWidgets/SDL2

Postby bit » Sun 20 Aug, 2017 6:19 am

These patches fixes real CD-ROM on Windows and adds a copy-button to the Configuration Manager.
Attachments
170820-config_sel_copy.zip
(4.96 KiB) Downloaded 11 times
170820-real_cdrom.patch
(1.18 KiB) Downloaded 11 times
SarahWalker
Site Admin
Posts: 1333
Joined: Thu 24 Apr, 2014 4:18 pm

Re: Patches for wxWidgets/SDL2

Postby SarahWalker » Mon 21 Aug, 2017 6:42 pm

Video update patch committed at rev 853.

Did you mean to make all the video options per-machine btw? Seems at least some of them would be better as globals.
SarahWalker
Site Admin
Posts: 1333
Joined: Thu 24 Apr, 2014 4:18 pm

Re: Patches for wxWidgets/SDL2

Postby SarahWalker » Mon 21 Aug, 2017 7:04 pm

Other patches committed in revs 854/855.
bit
Posts: 98
Joined: Sun 19 Mar, 2017 7:04 pm

Re: Patches for wxWidgets/SDL2

Postby bit » Wed 23 Aug, 2017 8:24 am

SarahWalker wrote:Did you mean to make all the video options per-machine btw? Seems at least some of them would be better as globals.

When I implemented GL3 I wanted the user to be able to have some settings different per-machine. And while I did that it felt strange to mix global-settings with machine-settings, so to minimize confusion I just did all of them as machine-settings.
But you're right that some of them would be better as globals. Do you think it's fine to mix them or should the global-settings be moved somewhere so it's more clear that they are globals?
ecksemmess
Posts: 122
Joined: Wed 18 Mar, 2015 5:27 am

Re: Patches for wxWidgets/SDL2

Postby ecksemmess » Wed 23 Aug, 2017 5:41 pm

I'd think that the UI should certainly make it very obvious to the user which settings will be applied globally and which will be applied per-machine. Lots of potential for confusion there.
bit
Posts: 98
Joined: Sun 19 Mar, 2017 7:04 pm

Re: Patches for wxWidgets/SDL2

Postby bit » Sun 27 Aug, 2017 8:39 pm

ecksemmess wrote:I'd think that the UI should certainly make it very obvious to the user which settings will be applied globally and which will be applied per-machine. Lots of potential for confusion there.

Yeah. My suggestions would be to either move all those menu-options to the menu in the machine-window called for example Global Settings or create a new settings-dialog for them.
User avatar
leilei
Posts: 436
Joined: Fri 25 Apr, 2014 4:47 pm

Re: Patches for wxWidgets/SDL2

Postby leilei » Mon 28 Aug, 2017 9:54 pm

I miss being able to go straight to hardware configuration from the main window menu bar. Have to pop open a new window which may be piled under the window and then find its menu bar and open it there :(
JosepMa
Posts: 70
Joined: Tue 20 Jun, 2017 6:25 pm

Re: Patches for wxWidgets/SDL2

Postby JosepMa » Thu 31 Aug, 2017 8:58 pm

There's an image missing in this commit:
https://bitbucket.org/JosepMaJaz/pcem/c ... 3af80a963f
wxrc -c pc.xrc -o wx-resources.cpp
22:55:34: Error: can't open file '.\icons/32x32/computer_go.png' (error 2: el sistema no puede encontrar el archivo especificado.)

Return to “Development”

Who is online

Users browsing this forum: Bing [Bot] and 1 guest