Tiny patch. Makefile "make clean" broken in msys/mingw.

Discussion of development and patch submission.
Post Reply
insidious611
Posts: 9
Joined: Sun 29 Mar, 2015 12:40 pm

Tiny patch. Makefile "make clean" broken in msys/mingw.

Post by insidious611 » Wed 01 Apr, 2015 9:46 pm

In Makefile.mingw, you seem to have forgotten that the "del" command doesn't exist within an msys shell, which is the preferred mingw dev environment.

Code: Select all

--- Makefile.mingw	2015-04-01 16:40:54 -0500
+++ Makefile.mingw	2015-04-01 16:41:11 -0500
@@ -33,9 +33,9 @@
 all : PCem.exe
 
 clean :
-	del *.o
-	del *.exe
-	del *.res
+	rm -f *.o
+	rm -f *.exe
+	rm -f *.res
 
 %.o : %.c
 	$(CC) $(CFLAGS) -c $<
this makes

Code: Select all

make -f Makefile.mingw clean

work properly.

User avatar
SarahWalker
Site Admin
Posts: 1529
Joined: Thu 24 Apr, 2014 4:18 pm

Re: Tiny patch. Makefile "make clean" broken in msys/mingw.

Post by SarahWalker » Thu 02 Apr, 2015 7:33 am

insidious611 wrote:In Makefile.mingw, you seem to have forgotten that the "del" command doesn't exist within an msys shell, which is the preferred mingw dev environment.
Yes, but it's not the one I use. Your patch would break "make clean" for me.

User avatar
ender
Posts: 51
Joined: Tue 14 Oct, 2014 12:51 pm

Re: Tiny patch. Makefile "make clean" broken in msys/mingw.

Post by ender » Sat 04 Apr, 2015 9:14 am

If you use GNU make, rm should work regardless of system (while del is limited to Windows).

User avatar
SarahWalker
Site Admin
Posts: 1529
Joined: Thu 24 Apr, 2014 4:18 pm

Re: Tiny patch. Makefile "make clean" broken in msys/mingw.

Post by SarahWalker » Tue 14 Apr, 2015 7:48 pm

Fixed in rev 224.

Post Reply