PCem has bug in ATA HDD geometry

Discussion of development and patch submission.
Post Reply
Jeditobe
Posts: 26
Joined: Thu 19 May, 2016 10:47 am

PCem has bug in ATA HDD geometry

Post by Jeditobe » Sat 08 Apr, 2017 5:33 pm

handled wrong (zero) HDD geometry info returned by PCem VM.


http://alter.org.ua/soft/win/uni_ata/

Version 0.46e3

User avatar
ppgrainbow
Posts: 468
Joined: Thu 04 Sep, 2014 7:03 am
Contact:

Re: PCem has bug in ATA HDD geometry

Post by ppgrainbow » Sat 08 Apr, 2017 7:44 pm

How did you know if the ATA HDD CHS geometry is not handled correctly?

User avatar
SarahWalker
Site Admin
Posts: 1726
Joined: Thu 24 Apr, 2014 4:18 pm

Re: PCem has bug in ATA HDD geometry

Post by SarahWalker » Sat 08 Apr, 2017 7:58 pm

Would you care to say what this bug is? Your post is probably the most vague bug report I've ever seen.

Battler
Posts: 793
Joined: Sun 06 Jul, 2014 7:05 pm

Re: PCem has bug in ATA HDD geometry

Post by Battler » Sat 08 Apr, 2017 8:29 pm

I suspect the driver the user linked to is simply too new for PCem - it seems to be a driver for 21st century hard disks, not for the 1990's hard disk PCem emulates that is supported out of the box by all of the OS'es listed on the driver's page.

Jeditobe
Posts: 26
Joined: Thu 19 May, 2016 10:47 am

Re: PCem has bug in ATA HDD geometry

Post by Jeditobe » Sat 08 Apr, 2017 9:31 pm

This driver is default in ReactOS. And ReactOS works in PCem

Jeditobe
Posts: 26
Joined: Thu 19 May, 2016 10:47 am

Re: PCem has bug in ATA HDD geometry

Post by Jeditobe » Sat 08 Apr, 2017 9:32 pm

SarahWalker wrote:Would you care to say what this bug is? Your post is probably the most vague bug report I've ever seen.
Looks like PCem sets Current Sectors/Heads to zero in HDD identify block.
This caused div-by-zero exception.


Battler
Posts: 793
Joined: Sun 06 Jul, 2014 7:05 pm

Re: PCem has bug in ATA HDD geometry

Post by Battler » Sun 09 Apr, 2017 9:02 am

It's still a bug in ReactOS, since the ATA standard has a flag in the identify block that tells whether or not the current sector/heads values can be trusted to be valid. ReactOS seems to completely ignore that and just assume those values can be trusted to be valid. I'd file a bug report with ReactOS, and point them at the ATA standard.

Jeditobe
Posts: 26
Joined: Thu 19 May, 2016 10:47 am

Re: PCem has bug in ATA HDD geometry

Post by Jeditobe » Sun 09 Apr, 2017 9:30 am

Battler
To report a bug you need to register first at the main site (reactos.org), then wait an hour, then use the same login:pass for jira.reactos.org.
Thanx in advance.

ecksemmess
Posts: 155
Joined: Wed 18 Mar, 2015 5:27 am

Re: PCem has bug in ATA HDD geometry

Post by ecksemmess » Mon 10 Apr, 2017 7:50 am

You're not seriously asking Battler to go file the bug report, are you? What possible reason could you have for not just doing it yourself?

Jeditobe
Posts: 26
Joined: Thu 19 May, 2016 10:47 am

Re: PCem has bug in ATA HDD geometry

Post by Jeditobe » Mon 10 Apr, 2017 12:13 pm

I am 100% serious.
Probably Battler knows this thing better than me to submit more accurate report than I could.

User avatar
gen_angry
Posts: 80
Joined: Sat 25 Feb, 2017 6:48 am

Re: PCem has bug in ATA HDD geometry

Post by gen_angry » Tue 11 Apr, 2017 1:19 am

^ lol.

Or you can do it yourself and point them to this thread if you want, it's not a PCem issue.

Jeditobe
Posts: 26
Joined: Thu 19 May, 2016 10:47 am

Re: PCem has bug in ATA HDD geometry

Post by Jeditobe » Tue 11 Apr, 2017 9:10 am

I can not because, I am not fully familiar with information Battler was talking about.

Post Reply