An oversight in the re-ordering of the ROM set enum in r346 has caused problems for the Phoenix 386 and the DTK 386, which have now lost their 386 classification. Actually, the problem was worse than that, as there were several misclassifications even before the re-ordering in r346 (IBM PS/1 Model 2011 classed improperly as 386+, for example). Attached is a patch that fixes all of that, and at the same time, I've taken the liberty of cleaning up some of the other silliness in the ROM set enum, which was on track to cause difficulties in the future whenever more PCI ROM sets are added. Obviously, everything in this patch is for ibm.h. I also note that there's a line in ibm.h as follows:
Code: Select all
#define AMIBIOS (romset==ROM_AMI386 || romset==ROM_AMI486 || romset == ROM_WIN486)
which is strange--obviously we've got quite a few other AMIBIOS machines at this point. Should they all be added? That would mean the line should be changed to:
Code: Select all
#define AMIBIOS (romset == ROM_AMIXT || romset == ROM_AMI286 || romset == ROM_AMI386 || romset == ROM_AMI486 || romset == ROM_WIN486 || romset == ROM_REVENGE || romset == ROM_ENDEAVOR)
Another thing--what is ROM_MISC286? It doesn't appear to actually be used anywhere...