[Patch] Show correct CPU speeds in Advanced/ZP's CMOS Setup

Post Reply
EluanCM
Posts: 112
Joined: Tue 27 Oct, 2015 2:07 pm
Location: Brazil
Contact:

[Patch] Show correct CPU speeds in Advanced/ZP's CMOS Setup

Post by EluanCM »

This is a small incomplete patch that enables the CMOS Setup of the Intel Zappa to show the correct CPU speed. I'd like some input in the incomplete parts.

It detects CPU type by comparing strings - this should NOT be done, but I couldn't think fast of a better way to do it. I was going to compare CPU speed and multiplier, but PCem's multiplier is an integer (and these CPUS have non-integer multipliers).
It also doesn't support the Overdrive CPUs because I don't know how they should be configured in the motherboard!
Attachments
zappa_cpu_speeds.patch
(3.34 KiB) Downloaded 626 times
User avatar
SarahWalker
Site Admin
Posts: 2055
Joined: Thu 24 Apr, 2014 4:18 pm

Re: [Patch] Show correct CPU speeds in Advanced/ZP's CMOS Setup

Post by SarahWalker »

Probably better to use the clockspeed in cpu_s->rspeed.
EluanCM
Posts: 112
Joined: Tue 27 Oct, 2015 2:07 pm
Location: Brazil
Contact:

Re: [Patch] Show correct CPU speeds in Advanced/ZP's CMOS Setup

Post by EluanCM »

I initially ran away from that because of the integer speed multiplier (so I couldn't disambiguate from 100/50 and 100/66), but I just used the PCI speed for that.

It's also curious that the keyboard detection fails at 120 and 133 MHz. I didn't look into that.
Attachments
zappa_cpu_speeds_v2.patch
(3.46 KiB) Downloaded 554 times
User avatar
SarahWalker
Site Admin
Posts: 2055
Joined: Thu 24 Apr, 2014 4:18 pm

Re: [Patch] Show correct CPU speeds in Advanced/ZP's CMOS Setup

Post by SarahWalker »

Committed at rev 1526. I also ported it to Advanced/EV (not that the BIOS for that board shows the CPU speed!), and fixed the keyboard detection above 100 MHz.
Post Reply